Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug+Fix] - Non base spells not being recognized #76

Closed
hewozuoai opened this issue Jan 12, 2025 · 1 comment · Fixed by #77
Closed

[Bug+Fix] - Non base spells not being recognized #76

hewozuoai opened this issue Jan 12, 2025 · 1 comment · Fixed by #77

Comments

@hewozuoai
Copy link
Contributor

Noticed this on a evoker.

For example;

Dream Breath (Spell ID: 355936) when talented for Font of Magic (Preservation) changes the spell ID to 382614.

I did some testing...

IsSpellKnown(382614) # false
IsSpellKnownOrOverridesKnown(382614) # true
C_Spell.PickupSpell(355936) # works
C_Spell.PickupSpell(382614) # doesn't work
FindBaseSpellByID(382614) # 355936

Can we add a further fallback option before

- something like;

                        -- another fallback option - try to get base spell
                        if not GetCursorInfo() then
                            local baseSpellId = FindBaseSpellByID(index)
                            if baseSpellId then
                                PickupSpell(baseSpellId)
                            end
                        end

I tested this locally and it works :)

@tg123
Copy link
Owner

tg123 commented Jan 12, 2025

sure
could you please send a pr?

hewozuoai pushed a commit to hewozuoai/myslot that referenced this issue Jan 13, 2025
@tg123 tg123 closed this as completed in #77 Jan 17, 2025
tg123 added a commit that referenced this issue Jan 17, 2025
* #76: Add FindBaseSpell fallback option

* Update Myslot.lua

Co-authored-by: Boshi Lian <[email protected]>

---------

Co-authored-by: hewozuoai <[email protected]>
Co-authored-by: Boshi Lian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants