#76: Add FindBaseSpell fallback option #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg123
requested changes
Jan 14, 2025
| @@ -752,6 +752,14 @@ function MySlot:RecoverData(msg, opt) | |||
| end | |||
| end | |||
|
|
|||
| -- another fallback option - try to get base spell | |||
| if not GetCursorInfo() then | |||
There was a problem hiding this comment.
Suggested change
| if not GetCursorInfo() then | |
| if not GetCursorInfo() and FindBaseSpellByID then |
work with client prior to 10.0
thanks, actually, i do not no this api, what i did, as you can see, is to create a CreateSpellOverrideMap
There was a problem hiding this comment.
did you mean to suggest the change above?
There was a problem hiding this comment.
yup, let me know if it looks good to you
There was a problem hiding this comment.
ahh i see what you mean, lgtm ill give it a quick test today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76.