chore(docs): Specify full path to xattr for macOS, fixes #2583 #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes th-ch#2583 On some Macs, Homebrew installs its own `xattr` which doesn't have the `-r` option. See th-ch#2583. This PR just adds the full path to the system `xattr` in `README.md`, so the `-r` in the instructions doesn't cause a problem. It's not clear to me whether or not the `-r` is required; this PR does not address that question, it just routes around it. I have tested the instruction on my Mac which has the Homebrew `xattr`, and with the added path, it works. I would assume this change is low risk; it's just to documentation, and the change points to a system command that should always be there. However, it's possible I'm missing corner cases that further testing and validation on more machines would uncover.
5 tasks
th-ch
approved these changes
Nov 9, 2024
th-ch
reviewed
Nov 9, 2024
Changed `xattr` instruction to `/usr/bin/xattr` in non-en README.md files. Fix for th-ch#2583. Done by recursive grep, so this should be all of them. Command line used: ```shell perl -p -i -e 's/^xattr/\/usr\/bin\/xattr/' `egrep -rl xattr .` ```
@th-ch, now applied to the other READMEs as well: es, fr, is, ko, ru. |
JellyBrick
approved these changes
Nov 10, 2024
JellyBrick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Macs, Homebrew installs its own
xattrwhich doesn't have the-roption. See #2583.This PR just adds the full path to the system
xattrinREADME.md, so the-rin the instructions doesn't cause a problem.It's not clear to me whether or not the
-ris required; this PR does not address that question, it just routes around it.I have tested the instruction on my Mac which has the Homebrew
xattr, and with the added path, it works.I would assume this change is low risk; it's just to documentation, and the change points to a system command that should always be there. However, it's possible I'm missing corner cases that further testing and validation on more machines would uncover.