Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

Load all files in a data directory: "_all.yml" and other files if present #89

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

jayvdb
Copy link
Collaborator

@jayvdb jayvdb commented Nov 17, 2018

This is a cherry-pick of 6e5dc92 from #67 .

I've tested it, and it works.

I can see some benefit in this, e.g. allowing _all.yml to contain vetted stable entries, or an archive, while new data files are created for new items, which might be migrated to _all.yml at a later date.

A database constraint occurs if the _all.yml and an individual data file contain the same key, which is appropriate. A follow up task can improve that to provide a better contextual message.

@jayvdb jayvdb requested a review from thanethomson November 17, 2018 15:37
@jayvdb
Copy link
Collaborator Author

jayvdb commented Nov 17, 2018

I'm happy to tidy, add tests, etc.

@thanethomson
Copy link
Owner

Sounds like a great idea 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants