Tweak pattern docs #187
Merged
Tweak pattern docs #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 61.52% 61.52%
=======================================
Files 28 28
Lines 1627 1627
=======================================
Hits 1001 1001
Misses 626 626 ☔ View full report in Codecov by Sentry. |
jariji
commented
Feb 29, 2024
| MLStyle.jl allows you to put guards anywhere during matching. | ||
|
|
||
|
|
||
| Sometimes, in practice, you might want to introduce type variables into the scope, in this case use `where` clause. See [Advanced Type Patterns](#advanced-type-patterns) for more details. |
There was a problem hiding this comment.
I didn't find these two paragrphs helpful so I removed them.
jariji
commented
Feb 29, 2024
|
|
||
| ```julia-console | ||
| julia> @data Color begin |
There was a problem hiding this comment.
It is not necessary to introduce ADTs here. struct is more familiar and does the job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a little better.
Closes #186