rust: bump ohkami to v0.21 #8180
Conversation
rust/ohkami/Cargo.toml
Outdated
| ohkami = { version = "0.20", features = ["rt_tokio"] } | ||
| tokio = { version = "1", features = ["macros", "rt-multi-thread"] } | ||
| ohkami = { version = "0.21", features = ["rt_tokio"] } | ||
| nio = { version = "0.0" } |
There was a problem hiding this comment.
what is the idea of this 0.0 ?
There was a problem hiding this comment.
Sorry, I forgot to chage features to ["rt_nio"] from ["rt_tokio"].
I'm trying nio experimental runtime instead of tokio here.
There was a problem hiding this comment.
could you then create okhami-nio and okhami-tokio ?
as we have for javascript with -bun and -deno
rust/ohkami/Cargo.toml
Outdated
| ohkami = { version = "0.20", features = ["rt_tokio"] } | ||
| tokio = { version = "1", features = ["macros", "rt-multi-thread"] } | ||
| ohkami = { version = "0.21", features = ["rt_tokio"] } | ||
| nio = { version = "0.0" } |
There was a problem hiding this comment.
could you then create okhami-nio and okhami-tokio ?
as we have for javascript with -bun and -deno
rust/ohkami-nio/Cargo.toml
Outdated
| [profile.release] | ||
| opt-level = 3 | ||
| debug = false | ||
| debug-assertions = false | ||
| lto = true | ||
| panic = "abort" | ||
| incremental = false | ||
| lto = true | ||
| panic = "abort" | ||
| codegen-units = 1 |
There was a problem hiding this comment.
not needed 😛
compilation options are in rust/Dockerfile
what is codegen-units for ?
| [profile.release] | ||
| lto = true | ||
| panic = "abort" | ||
| codegen-units = 1 |
There was a problem hiding this comment.
| [profile.release] | |
| lto = true | |
| panic = "abort" | |
| codegen-units = 1 |
There was a problem hiding this comment.
They're quite standard optimizations for release profile ( other rust frameworks do the same in their Cargo.tomls, too )
There was a problem hiding this comment.
now almost all rust/* are using
[profile.release]
opt-level = 3
debug = false
debug-assertions = false
lto = true
panic = "abort"
incremental = false
codegen-units = 1
rpath = false
strip = false( see their Cargo.tomls )
but actually other than lto = true, panic = "abort" and codegen-units = 1 are default configuration of release profile, so I just set them
There was a problem hiding this comment.
I removed them in current branch, from advice of @msrd0. The compilation step is
cargo build --release \
--config 'profile.release.lto=true' \
--config 'profile.release.panic="abort"' \
--config 'profile.release.codegen-units=1'
No description provided.