Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created footer #67

Merged
merged 3 commits into from
Oct 17, 2024
Merged

created footer #67

merged 3 commits into from
Oct 17, 2024

Conversation

EmmaBin
Copy link
Collaborator

@EmmaBin EmmaBin commented Oct 13, 2024

Description

Add a footer to include developers and mentors' links.

Related Issue

closes #61

Acceptance Criteria

  • There is a consistent footer across the app that includes all developer names and links as well as mentors' to LinkedIn profiles

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.
enhancement

Updates

Before

After

Screenshot 2024-10-12 at 5 38 09 PM

Testing Steps / QA Criteria

  1. go to eb-add-footer
  2. Check on different pages to test if the footer stays on the bottom
  3. All links should work properly

Copy link

github-actions bot commented Oct 13, 2024

Visit the preview URL for this PR (updated for commit 628137c):

https://tcl-76-smart-shopping-list--pr67-eb-add-footer-l1t5d6e5.web.app

(expires Thu, 24 Oct 2024 06:37:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

Copy link
Collaborator

@sar-mko sar-mko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot! Nice job, and links are all working well. Im curious though If there is a way to show the mentors' mention without a scroll, so that the footer is sticky to the bottom.

@EmmaBin
Copy link
Collaborator Author

EmmaBin commented Oct 15, 2024

I like it a lot! Nice job, and links are all working well. Im curious though If there is a way to show the mentors' mention without a scroll, so that the footer is sticky to the bottom.

I updated home page view height, I believe the footer now sticks to the bottom without any scrolling

Copy link
Collaborator

@arandel1 arandel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Let's make our names and the mentors names listed in alphabetical order by last name, if possible. Also I'm curious what it would look like if it were a little smaller or more subtle -- perhaps one line?
"Developed by: Emma Ma, Sarah Mekonnen, Marcos Perez, and Allison Randel. Special thanks to our mentors: Nathan Brown, Devin Jaggernauth, and Mindy Zwanziger."

@EmmaBin EmmaBin merged commit 1e2cf7f into main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

33. As a user, I want to be able to contact the creators of the app
3 participants