Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share your existing shopping list with other users #23

Merged
merged 5 commits into from
Aug 31, 2024

Conversation

eva-lng
Copy link
Collaborator

@eva-lng eva-lng commented Aug 30, 2024

Type
New Feature
Share your shopping list with another user

Description

We implemented a new feature where a logged in user can share an existing shopping list they created with another existing user. In ManageList view we created a new form to input the email of the other user being invited to the shopping list and implemented shareList function to share the list. In firebase.js we made adjustment to the shareList function to make sure the user sharing their list receives status messages regarding their request, including alerts when the submitted email doesn't belong to any registered user or when the user tries to share a list they didn't create.

Related Issue

Closes #6

Acceptance Criteria

  •  The ManageList view shows a form that allows the user to enter an email to invite an existing user to a list, in addition to the form that allows them to add items to that list.
  •  The input that accepts the email has a semantic label element associated with it
  •  The user can submit this form with both the mouse and the Enter key
  •  If the other user exists, the user is alerted that the list was shared
  •  If the other user does not exist, the user is shown an error message that explains the problem

Type of Changes

new feature

Updates

Before

Screenshot 2024-08-30 at 16 47 50

After

Screenshot 2024-08-30 at 16 48 48

Screenshot 2024-08-30 at 16 58 39

Screenshot 2024-08-30 at 16 59 54

Testing Steps / QA Criteria

npm start
navigate to Home view and click on a list you want to share
navigate to ManageList view, type an email of an existing user in the correct form and submit

to check for alert messages:

  • select a shopping list that you did not create (e.g. test-list) and share it
  • share a shopping list you created with a non-existing user email

Copy link

Visit the preview URL for this PR (updated for commit 04fcf81):

https://tcl-78-smart-shopping-list--pr23-dc-el-invite-others-4fr1u2vw.web.app

(expires Fri, 06 Sep 2024 15:13:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@GrannyYetta GrannyYetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

Copy link
Contributor

@tataw-cl tataw-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work guys

@eva-lng eva-lng merged commit 2e2cc1e into main Aug 31, 2024
2 checks passed
Copy link
Collaborator

@vivitt vivitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work team! ✨
Your code looks great, and the new feature works well.

I like how you've handled the error messages in your implementation when something goes wrong. A possible improvement could be to clear the message once the user starts typing in the field again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6. As a user, I want to be able to invite others to an existing shopping list
5 participants