-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share your existing shopping list with other users #23
Conversation
…nt error messages in ManageList view
Visit the preview URL for this PR (updated for commit 04fcf81): https://tcl-78-smart-shopping-list--pr23-dc-el-invite-others-4fr1u2vw.web.app (expires Fri, 06 Sep 2024 15:13:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c781903507c1507075d7a974036959ddeec29c0a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work guys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work team! ✨
Your code looks great, and the new feature works well.
I like how you've handled the error messages in your implementation when something goes wrong. A possible improvement could be to clear the message once the user starts typing in the field again.
Description
We implemented a new feature where a logged in user can share an existing shopping list they created with another existing user. In
ManageList
view we created a new form to input the email of the other user being invited to the shopping list and implementedshareList
function to share the list. Infirebase.js
we made adjustment to theshareList
function to make sure the user sharing their list receives status messages regarding their request, including alerts when the submitted email doesn't belong to any registered user or when the user tries to share a list they didn't create.Related Issue
Closes #6
Acceptance Criteria
ManageList
view shows a form that allows the user to enter an email to invite an existing user to a list, in addition to the form that allows them to add items to that list.label
element associated with itEnter
keyType of Changes
new feature
Updates
Before
After
Testing Steps / QA Criteria
npm start
navigate to
Home
view and click on a list you want to sharenavigate to
ManageList
view, type an email of an existing user in the correct form and submitto check for alert messages:
test-list
) and share it