Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display prompts to direct user flow on sign in #24

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

tataw-cl
Copy link
Contributor

@tataw-cl tataw-cl commented Sep 6, 2024

Description

Display conditional prompts directing the user what next steps to take when on the 'List' and 'Home' pages. If the user has no lists created, they're prompted to create one on the 'Home' page, then on the 'List' page, there are prompting texts and links to direct the user if they don't have a list yet, or if they haven't added any items to their created shopping lists.
We choose this approach si9nce it was the most intuitive in closing our issue and used conditionals in the 'list' and 'home' pages added to text prompts

Related Issue

closes #8

Acceptance Criteria

  • The list view, when there are no items to display, should show a prompt (e.g., a button) for the user to add their first item
  • The home view, when there are no lists to display, should show a prompt (e.g., a button) for the user to add their first shopping list

Type of Changes

enhancement

Updates

Before

Before-Home
Before-List

After

After-Home
After-List

Testing Steps / QA Criteria

  • switch to the branch el-tc-empty-list-prompt by doing git pull el-tc-empty-list-prompt in your terminal on the main branch
  • then type git checkout el-tc-empty-list-prompt
  • then run npm start
  • navigate to the Home page and List page with an email account which has no lists created to see changes

Copy link

github-actions bot commented Sep 6, 2024

Visit the preview URL for this PR (updated for commit 55abb1f):

https://tcl-78-smart-shopping-list--pr24-el-tc-empty-list-pro-jnoemgim.web.app

(expires Sun, 15 Sep 2024 11:53:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

@tataw-cl tataw-cl requested review from Amaka202 and vivitt September 6, 2024 14:12
@didemydn
Copy link
Collaborator

didemydn commented Sep 7, 2024

thanks, guys! It seems working well but I have a question
this is my home page

image

There is no list on my home page, and your issue works well, but when I go to the list page, I see the items and cannot navigate the manage list. Also, I deleted all my lists from the Firebase store. why do I see the search items in my list view?

image

@GrannyYetta
Copy link
Collaborator

Hi Eva and Tataw,

thank you for the PR.

I am not getting the prompt in my home view:

Captura de pantalla 2024-09-07 a la(s) 20 34 59

I am also not getting a prompt in my List view:

Captura de pantalla 2024-09-07 a la(s) 20 36 05

Could this be specific to my browser?

@tataw-cl
Copy link
Contributor Author

tataw-cl commented Sep 8, 2024

Thanks for the comments guys, I believe Eva has fixed the issue more. And as for @GrannyYetta, I think the issue should be your browser I guess, cause it works well overall on our side

Copy link
Collaborator

@Amaka202 Amaka202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weldone guys! your feature works well!✅💥

@eva-lng eva-lng merged commit e787557 into main Sep 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants