Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling for all forms #54

Closed
wants to merge 2 commits into from
Closed

Add styling for all forms #54

wants to merge 2 commits into from

Conversation

tataw-cl
Copy link
Contributor

@tataw-cl tataw-cl commented Oct 5, 2024

Description

Basic form styling is added to all forms in the app as well as a border to make them more visible throughout the application

Related Issue

closes #53

Acceptance Criteria

  • All forms in components should be differentiable from the rest of the site elements.
  • All form inputs should have a light border outline so they can be easily identified for input when a user lands on a page.
  • Use minimal color related styling for backgrounds since the app background is still pending.

Type of Changes

enhancement

Updates

Before

Before-home
Before-list

After

After-home
After-List (2)

Testing Steps / QA Criteria

  • switch to the branch by running git checkout tc-form-styling
  • run npm start
  • Navigate to the pages of the applicating and check out the forms and looks on each.

Copy link

github-actions bot commented Oct 5, 2024

Visit the preview URL for this PR (updated for commit 96293ee):

https://tcl-78-smart-shopping-list--pr54-tc-form-styling-2hnko95z.web.app

(expires Sat, 12 Oct 2024 14:25:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@eva-lng eva-lng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for now as a first styling. In the future issues, we will need to address the general layout of the forms (e.g. positions of inputs and buttons, spacing, handling of labels etc.) to make them them visually consistent

@Amaka202
Copy link
Collaborator

Amaka202 commented Oct 6, 2024

Works fine for now as a first styling. In the future issues, we will need to address the general layout of the forms (e.g. positions of inputs and buttons, spacing, handling of labels etc.) to make them them visually consistent

Ok then this puts alot of perspective to it. Also the texts needs some more alignments too. Well done so far team!💥💥

Copy link
Collaborator

@Amaka202 Amaka202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on the work so far! ✅

@eva-lng eva-lng closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

53: As a user, I want all the forms in my app to have a user friendly and consistent look.
3 participants