Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urgency category colors changed #62

Merged
merged 1 commit into from
Oct 12, 2024
Merged

urgency category colors changed #62

merged 1 commit into from
Oct 12, 2024

Conversation

didemydn
Copy link
Collaborator

Description

the color scheme for urgency categories in the list view to improve clarity and user experience.

Related Issue

closes #61

Acceptance Criteria

  • the urgency category colors to be changed

Type of Changes

urgency category colors have been adjusted, they are more readable and compatible, selected a more pastel color.

Updates

Before

image

After

image

Copy link

Visit the preview URL for this PR (updated for commit ceb6e5a):

https://tcl-78-smart-shopping-list--pr62-dc-category-colors-64h3chcm.web.app

(expires Thu, 17 Oct 2024 19:48:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@eva-lng eva-lng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label colors work nicely with both light and dark mode. One suggestion - I would change the label font back to light. When it's in bold it draws the attention away form the list item itself and puts too much focus on the label

Copy link
Collaborator

@vivitt vivitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨
I really like the color choices! I agree with Eva that a thinner font might work better for the labels, but I love that you kept black for the font color. I think it makes the labels more legible. Nice job!

@eva-lng eva-lng removed the request for review from Amaka202 October 12, 2024 08:46
@didemydn didemydn merged commit c4e6a80 into main Oct 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List view urgency category colors updates.
3 participants