Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected routes #65

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Protected routes #65

merged 2 commits into from
Oct 16, 2024

Conversation

eva-lng
Copy link
Collaborator

@eva-lng eva-lng commented Oct 15, 2024

Description

Users are automatically redirected to Home view after they sign out.

Related Issue

closes #64

Acceptance Criteria

  • After signing out, users should be automatically redirected to Home view

Type of Changes

new feature

Testing Steps / QA Criteria

npm start
navigate to browser and sign in
navigate to List or Share view and sign out, you should be redirected back to Home view

@eva-lng eva-lng requested review from Amaka202 and vivitt October 15, 2024 17:01
Copy link

Visit the preview URL for this PR (updated for commit 4bfd54a):

https://tcl-78-smart-shopping-list--pr65-el-protected-routes-n3cfoq55.web.app

(expires Tue, 22 Oct 2024 17:02:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@vivitt vivitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ✨
Private routes are well implemented and everything is working as expected

@eva-lng eva-lng removed the request for review from Amaka202 October 16, 2024 14:57
@eva-lng eva-lng merged commit 4ed1c09 into main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

64. Redirecting users after signing out
2 participants