Numba reduced set #738
Open
Numba reduced set #738
+356
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liadomide @maedoc could you please review the following PR. Moreover, can you please guide me on how to test the reproducibility of similar results in old and new code. Thanks! |
|
hi, thanks for your contribution. In fact, we cannot accept the current modifications because the existing NumPy code is the reference implementation. Instead, I would suggest approaching this by creating a separate Numba implementation, not modifying in-place the existing NumPy code. This would then allow you to test your Numba against the existing NumPy code. |
|
@maedoc added back the numpy code. Can you please tell how can I carry out the testing ( I am quite new to TVB, apologies if it's something trivial). Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #544