feat(android): RN-0.73 and Android Gradle Plugin 8.0 Compatibility Fix #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishantwalia
changed the title
dishantwalia
changed the title
mikehardy
reviewed
Jan 26, 2024
mikehardy
reviewed
Jan 26, 2024
mikehardy
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
this now corresponds to the way I've done it in other modules which will emit a warning because of the AndroidManifest.xml contents but will still work for people on all versions of AGP (5, 6, 7 and 8)
This corresponds to the patch I'm currently using in my work apps for this module and works + is in production / tested
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
## [12.1.3](v12.1.2...v12.1.3) (2024-01-26) ### Bug Fixes * **android:** add gradle namespace for react-native 0.73 / android gradle plugin 8.0 ([#485](#485)) ([d7f506d](d7f506d)) * **deps, ios:** use facebook-ios-sdk 16.3.1 ([e612900](e612900)) ### Performance Improvements * **ci:** we know the exact paths of the files to use for cache freshness ([305fcd0](305fcd0))
|
🎉 This PR is included in version 12.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
react-native-community/discussions-and-proposals#671
React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x. This will require all the libraries to specify a namespace in their build.gradle file. We added a compatibility layer for libraries that haven't specified a namespace, but please consider updating your libraries nonetheless.