Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add replace for the new AD_SERVICES_CONFIG introduced in V18 #600

Merged
merged 3 commits into from
Jan 26, 2025
Merged

fix: add replace for the new AD_SERVICES_CONFIG introduced in V18 #600

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac6a4f0
chore: add override for the new AD_SERVICES_CONFIG introduced in V18
TheRogue76 Jan 26, 2025
c4c3a72
Update android/src/main/AndroidManifest.xml
mikehardy Jan 26, 2025
0f6f881
Update android/src/main/AndroidManifest.xml
mikehardy Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,29 @@
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-->

<manifest
package="com.facebook.reactnative.androidsdk">
<!--
This may generate a warning during your build:

> property#android.adservices.AD_SERVICES_CONFIG@android:resource
> was tagged at AndroidManifest.xml:23 to replace other declarations
> but no other declaration present

You may safely ignore this warning.

We must include this in case you also use something else
that may also include this file, because if two modules include it, they
will collide and cause a build error if we don't set this one to take
priority via replacement.

https://github.com/thebergamo/react-native-fbsdk-next/issues/597
-->
<manifest package="com.facebook.reactnative.androidsdk"
mikehardy marked this conversation as resolved.
Show resolved Hide resolved
xmlns:tools="http://schemas.android.com/tools"
xmlns:android="http://schemas.android.com/apk/res/android">
<application>
<property
android:name="android.adservices.AD_SERVICES_CONFIG"
android:resource="@xml/ad_services_config"
tools:replace="android:resource" />
</application>
</manifest>
Loading