Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring links table #371

Closed

Conversation

glenn-louarn
Copy link
Contributor

Reafactoring file LinksTable in several small components :
Advantage : increase lisibility and maintainability
It also include search page PR #353, translate #354 and theme #347

  • +Links
    • +Linkstable
      • +Item
        • -Action.tsx
        • -Actions.tsx
        • -EditForm.tsx
        • -Item.tsx
    • -Header.tsx
    • -Linkstable.tsx
    • +Modal
      • -BanModal.tsx
      • -DeleteModal.tsx
      • -QRCodeModal.tsx
    • -Footer.tsx
    • -Header.tsx
    • -Links.tsx
    • -Nav.tsx

@poeti8
Copy link
Contributor

poeti8 commented Aug 14, 2020

I wish you could make PR without including code from other PRs. It's easier to review and merge.

@glenn-louarn
Copy link
Contributor Author

Hello,
I am reworking the PRs so they are independant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants