-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Serde Data Format for JsValue #74
base: master
Are you sure you want to change the base?
Conversation
I took a swing at
This would still have all of the convenience, but give us the freedom to have all of the necessary trait implementations that we will need to make this work. @theduke I would appreciate your feedback on this conjecture! |
@semirix I have not spent anymore time on this for various reasons. 1) I would like @theduke to weigh in if this PR looks good so far and if my proposed changes going forward are acceptable before I spend more time on this (Some of the changes I proposed introduce potential API breakage). 2) I have been short on time as of late, due to other responsibilities. I agree that I would love to have this integrated. It would be very useful. |
This PR provides a custom serde data format for serializing/deserializing Rust data structures into/from
JsValue
.Serialization Example:
Deserialization Example:
I've been slowly working on this for a while, and -- while it is definitely not finished yet -- I thought I would open this PR and gather early feedback. I have been wanting this for quickjs-rs in my own projects, so I'm curious to see if we can 1) get this reviewed and incorporate early feedback, 2) I can work more on the outstanding items listed below, 3) merge!
TODO:
#10 #64