Adding missing dns_proxy and description arguments to domain role #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Domain tests seem to be fixed, but I don't understand the issue that is present currently. Could sombody review this and give me a hint where to look? Thanks! |
Ignore that, it's fixed in #1707 |
evgeni
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the role's description stating that
descriptionanddns_proxyare being passed to the module call oftheforeman.foreman.domain, these attributes are not passed to it.This PR fixes that by passing both
descriptionanddns_proxyto the module call if specified. They will be omitted by default.