-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix container search bats issue with a delay #1864
Attempt to fix container search bats issue with a delay #1864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of using sleep as a synchronization mechanism. Is there a reason podman push
returns before it becomes visible? Does the spec for pushes say anything about this?
Note I don't object to merging this, but I'd at least like to understand it.
I don't like the sleep either, but so far it's only reproducible on the test upgrade pipeline for centos9-stream in CI, not even locally. There shouldn't be any delay. Since the push appears to be working, this sleep should at least tell is if its timing, or if there's a rare bug going on where the container repo isn't getting pushed properly. I suppose either way it's a rare bug :) |
My thought is to remove the sleep as soon as possible since I'm not sure how else to debug the CI pipeline. |
Did you run the pipeline locally? |
Yeah this was tested last week:
|
Just popping in to say that the pipeline passed, so the issue is indeed intermittent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does sound like a timing issue. Mind adding a comment to explain? Perhaps just link to this PR
75427f6
to
1e54e65
Compare
5 seconds should be adequate. If it's not the case, then we likely have a podman push bug somewhere.