update foreman-maintain before stopping services #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures any possible fixes for process handling are available.
|
I am unsure I want to keep this forever (as it's how a Satellite upgrade works under the hood) and update our docs, or just use it to test the fix for https://community.theforeman.org/t/katello-nightly-rpm-pipeline-2155-failed/39693/ and backport the actual fix to the 1.7.z branch afterwards. |
ehelms
approved these changes
Oct 15, 2024
ekohl
approved these changes
Oct 15, 2024
|
FWIW, https://ci.theforeman.org/job/katello-nightly-rpm-pipeline/2168/ passed with this, so I'll go about to backport that change to 1.7.x and we can revert this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures any possible fixes for process handling are available.