Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting script #201

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: linting script #201

merged 1 commit into from
Sep 19, 2023

Conversation

Sqrcz
Copy link
Collaborator

@Sqrcz Sqrcz commented Sep 19, 2023

  • npm run lint was missing a directory to lint
  • added . as directory to lint
  • changed src to . in npm run lint-fix
  • added .js ext to linter

. lints also files we have in root

 - `npm run lint` was missing a directory to lint
 - added `.` as directory to lint
 - changed `src` to `.` in `npm run lint-fix`
 - added `.js` ext to linter

 . lints also files we have in root
@cogor cogor added 🔧 enhancement New feature or request ✨ good first issue Good for newcomers labels Sep 19, 2023
@cogor cogor assigned cogor and unassigned cogor Sep 19, 2023
@cogor cogor self-requested a review September 19, 2023 14:35
@cogor cogor added this to the 0.0.17 milestone Sep 19, 2023
@Sqrcz
Copy link
Collaborator Author

Sqrcz commented Sep 19, 2023

@cogor do you want me to fix linting errors since linting started working again?

@cogor
Copy link
Collaborator

cogor commented Sep 19, 2023

You can fix them, or I fix them after merge

@cogor
Copy link
Collaborator

cogor commented Sep 19, 2023

LGTM

@cogor cogor merged commit e749fd7 into themesberg:main Sep 19, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 enhancement New feature or request ✨ good first issue Good for newcomers
Development

Successfully merging this pull request may close these issues.

2 participants