WIP: Refactor to make linting more strict #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ dependencies updated
Sqrcz
commented
Sep 20, 2023
Sqrcz
commented
Sep 20, 2023
Sqrcz
commented
Sep 20, 2023
Sqrcz
commented
Sep 20, 2023
Sqrcz
commented
Sep 20, 2023
Sqrcz
commented
Sep 20, 2023
|
Looks great, you can start making changes to comply with the new rules |
- component - docs
- component - docs
|
I've updated this PR with changes to Paragraph and Heading components... it covers components as well as docs for them. Let me know if that is ok... and I'll work on the rest of the components. Also... this PR will affect most of the files... so if you have some work in progress let's figure out how to best avoid conflicts ;) |
|
That is ok, but need to fix an error in docs :) |
cogor
reviewed
Sep 21, 2023
Co-authored-by: Ilya Artamonov <[email protected]>
|
good catch, thanks cool... I'll continue with other components |
- component - docs
- component - docs
- component - docs
- component - docs
- component names come from the file name
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
- component - docs
Merged
|
Hey... this is still WIP... I have few more components to go through... ;) |
|
I know, I merged it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Based on the discussion here: #200
This is my proposal for updating linting rules... (details in comments below).
This is Draft PR as if changes are accepted it'll be required to actually implement new rules... this can be done as part of this commit (but it would make it very big) or as separated piece of work after this one is accepted.
When updating linting dependencies I've also updated existing ones as well.
Pleas let me know if this set of rules is acceptable... If yes I'll prepare next one to implement necessary changes to align with those rules.