-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update disabledClasses in FwbPagination.vue #319
Conversation
The disabledClasses variable in FwbPagination.vue has been updated to use the "disabled:opacity-50 disabled:cursor-not-allowed" classes instead of the previous "bg-gray-100 text-gray-700 dark:bg-gray-700 dark:text-white cursor-not-allowed" classes. This change improves the consistency and readability of the code.
WalkthroughThe recent changes in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/FwbPagination/FwbPagination.vue (1 hunks)
Additional comments not posted (1)
src/components/FwbPagination/FwbPagination.vue (1)
282-282
: Approved: SimplifieddisabledClasses
with Tailwind CSS utilities.The update to use
"disabled:opacity-50 disabled:cursor-not-allowed"
improves maintainability and aligns with Tailwind's utility-first design philosophy. Ensure that the logic for applying these classes in thegetNavigationButtonClasses
function is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Thank you 🙌
Update for point 20. on #236
Flowbite React taken as an example.
The disabledClasses variable in FwbPagination.vue has been updated to use the
"disabled:opacity-50 disabled:cursor-not-allowed"
classes instead of the previous"bg-gray-100 text-gray-700 dark:bg-gray-700 dark:text-white cursor-not-allowed"
classes. This change improves the consistency and readability of the code.I hope it turned out the way you wanted. Please check it out and feel free to give feedback.
@cogor @Sqrcz
Summary by CodeRabbit