-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FwbCard: Removed hover on non-links cards #321
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce an optional Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/FwbCard/composables/useCardClasses.ts (1 hunks)
Additional comments not posted (1)
src/components/FwbCard/composables/useCardClasses.ts (1)
6-6
: Addition ofhref
property approved.The addition of the optional
href
property toUseCardsClassesProps
is well-implemented and aligns with the PR's objective to conditionally apply hover effects based on the presence of a link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/FwbCard/composables/useCardClasses.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/components/FwbCard/composables/useCardClasses.ts
Current implementation of card has hover effect for the case when the card is not a link.
And on the other hand it does not have hover effect for the case when the card contains image and has a link.
This PR fixes this behavior
Summary by CodeRabbit
New Features
href
property to enhance the card component's functionality, allowing for hyperlinking capabilities.href
property, enhancing user interaction.Refactor
href
property and improve responsiveness.