Fix text field tests

theopensystemslab · Jan 28, 2025 · 5c61b9f · 5c61b9f
1 parent fbfd644
commit 5c61b9f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/editor.planx.uk/src/@planx/components/TextInput/Public.tsx b/editor.planx.uk/src/@planx/components/TextInput/Public.tsx
@@ -34,7 +34,7 @@ const TextInputComponent: React.FC<Props> = (props) => {
 
   const characterCountLimit = props.type && getTextLimit(props.type);
   const displayCharacterCount =
-    props.type !== TextInputType.Short && characterCountLimit;
+    Boolean(props.type !== TextInputType.Short && characterCountLimit);
 
   return (
     <Card handleSubmit={formik.handleSubmit} isValid>

diff --git a/editor.planx.uk/src/@planx/components/shared/Schema/InputFields/TextFieldInput.tsx b/editor.planx.uk/src/@planx/components/shared/Schema/InputFields/TextFieldInput.tsx
@@ -15,6 +15,11 @@ export const TextFieldInput: React.FC<Props<TextField>> = (props) => {
   const { id, errorMessage, required, title } = fieldProps;
 
   const characterCountLimit = data.type && getTextLimit(data.type);
+
+  const displayCharacterCount = Boolean(
+    data.type !== TextInputType.Short && characterCountLimit
+  );
+
   return (
     <InputLabel label={title} htmlFor={id}>
       {data.description && (
@@ -45,7 +50,7 @@ export const TextFieldInput: React.FC<Props<TextField>> = (props) => {
             .join(" "),
         }}
       />
-      {characterCountLimit && (
+      {displayCharacterCount && (
         <CharacterCounter
           textInputType={data.type || TextInputType.Long}
           count={fieldProps?.value?.length}