chore: Improve email failure logging (#4209)

theopensystemslab · Jan 25, 2025 · a7eff12 · a7eff12
1 parent 5607aff
commit a7eff12
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/api.planx.uk/modules/sendEmail/controller.ts b/api.planx.uk/modules/sendEmail/controller.ts
@@ -27,7 +27,7 @@ export const singleApplicationEmailController: SingleApplicationEmail = async (
     });
     return res.json(response);
   } catch (error) {
-    emailErrorHandler(next, error, template);
+    emailErrorHandler(next, error, template, sessionId);
   }
 };
 
@@ -42,7 +42,12 @@ export const paymentEmailController: PaymentEmail = async (_req, res, next) => {
     });
     return res.json(response);
   } catch (error) {
-    emailErrorHandler(next, error, template);
+    emailErrorHandler(
+      next,
+      error,
+      template,
+      `(payment request) ${paymentRequestId}`,
+    );
   }
 };
 
@@ -69,19 +74,20 @@ export const confirmationEmailController: ConfirmationEmail = async (
       return res.json(response);
     }
   } catch (error) {
-    emailErrorHandler(next, error, template);
+    emailErrorHandler(next, error, template, sessionId);
   }
 };
 
 const emailErrorHandler = (
   next: NextFunction,
   error: unknown,
   template: string,
+  sessionId: string,
 ) =>
   next(
     new ServerError({
       status: error instanceof ServerError ? error.status : undefined,
-      message: `Failed to send "${template}" email. ${
+      message: `Failed to send "${template}" email for session ${sessionId}. ${
         (error as Error).message
       }`,
     }),