chore: Clean up types

theopensystemslab · Dec 12, 2023 · c20cd16 · c20cd16
1 parent c5342aa
commit c20cd16
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/api.planx.uk/modules/webhooks/service/validateInput/schema.ts b/api.planx.uk/modules/webhooks/service/validateInput/schema.ts
@@ -19,27 +19,30 @@ type HasuraValidateInputRequestSchema = z.infer<
   typeof hasuraValidateInputRequestSchema
 >;
 
-interface IsCleanJSONBSchema {
+interface IsCleanJSONBTransformedRequest {
   body: {
     isClean: boolean;
   };
 }
 
+type isCleanJSONBSchema = z.ZodType<
+  IsCleanJSONBTransformedRequest,
+  z.ZodTypeDef,
+  HasuraValidateInputRequestSchema
+>;
+
 /**
  * Schema which iterates over values of a JSONB column
  * Checks using DOMPurify to ensure that user-submitted HTML is clean
  * Fails fast - will reject on first instance of unclean HTML
  */
-export const isCleanJSONBSchema: z.ZodType<
-  IsCleanJSONBSchema,
-  z.ZodTypeDef,
-  HasuraValidateInputRequestSchema
-> = hasuraValidateInputRequestSchema.transform((original) => {
-  const isClean = original.body.data.input.every((input) =>
-    isObjectValid(input, isCleanHTML),
-  );
-  return { body: { isClean } };
-});
+export const isCleanJSONBSchema: isCleanJSONBSchema =
+  hasuraValidateInputRequestSchema.transform((original) => {
+    const isClean = original.body.data.input.every((input) =>
+      isObjectValid(input, isCleanHTML),
+    );
+    return { body: { isClean } };
+  });
 
 export type IsCleanJSONBController = ValidatedRequestHandler<
   typeof isCleanJSONBSchema,