-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display external portals on readme page + test coverage #4177
Conversation
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (2)
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great - a few very minor comments.
Couldn't get to the bottom of the testing issue, but totally agree it's non-functional and something to do with the interacting of vitest and zustand - all working as expected for a user 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is shared outside the context of search, we should probably move it to a shared location.
In this PR:
Testing issues
In the test
it("displays data in the fields if there is already flow information in the database"
, it only worked if I set just one piece of state. If I set two fields in state:...it would find the first piece of text in the document but not the second. When I logged what was in the store on the component page, both pieces of text were in the store on a first render, and then both were
""
on the second render. Withscreen.debug
onlyserviceSummary
had a value displayed.I'm wondering if this is a timing issue and too many re-renders, but wasn't really sure how to debug where the re-renders are coming from. I wasn't able to recreate this with the profiling tool in React dev tools (although it did show a high number of re-renders when the inputs are typed in, which makes sense as they re-render on every keystroke).