Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align delete button for exclusive or option #4180

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jan 22, 2025

Small style issue I just noticed. This "flex-end" style was introduced by me here - https://github.com/theopensystemslab/planx-new/pull/2878/files#diff-7c9507182b77eae18c81c9e8bbf8c4026130ba642daa86a1eb9a52c492d17911R80

I've checked the Pay component's metadata section, and it's still visually the same with this change in place.

Before - staging
Delete button is aligned to top on options, and bottom on exclusive option
image

After - this PR
Both delete buttons aligned in the same spot
image

@DafyddLlyr DafyddLlyr requested a review from a team January 22, 2025 11:41
Copy link

github-actions bot commented Jan 22, 2025

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit 181fd8d into main Jan 22, 2025
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/exclusive-or-delete-button-alignment branch January 22, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants