fix: Use current values to populate DataAutocomplete options, not just static initial values
#4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
DataAutocomplete): Use current values, not just initial values
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/focus-bug-data-autocomplete
branch
from
aa66be5 to
cc21861
Compare
DafyddLlyr
force-pushed
the
dp/focus-bug-data-autocomplete
branch
from
cc21861 to
82011ca
Compare
DafyddLlyr
changed the title
DataAutocomplete): Use current values, not just initial valuesDataAutocomplete options, not just static initial values
jessicamcinchak
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
The
DataAutocompletecomponent is not aware of the current status of the form, just the initial status. As I enter new values across fields, I should be able to reference and select them within my component. Raised here as an issue on OSL Slack - https://opensystemslab.slack.com/archives/C5Q59R3HB/p1737660734834029?thread_ts=1737640916.451959&cid=C5Q59R3HBWhat's the solution?
Rather than just entering the
formik.initialValuesas the schema, dynamically pass the currentformik.values. As I enter new values across the current component, I can see this change reflected across all myDataAutocompletecomponents.To test..
Please watch video in Slack thread referenced above for context