fix: Add login check on /download-schema route
#4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
\/download-schema route/download-schema route
|
Removed vultr server and associated DNS entries |
jamdelion
approved these changes
Jan 28, 2025
DafyddLlyr
force-pushed
the
dp/login-auth-flows-endpoints
branch
from
d79a458 to
4302122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Only allows authenticated users to access the
/download-schemaroute by applying theuseLoginAuth()middleware.Why?
This was flagged by the pen test. Whilst there's no security issue here - the flow data should be public, there is a performance concern for exposing this endpoint. This isn't a public feature, and a potentially expensive request - it could degrade performance if this was hit over and over.