test: Update metabase tests for latest vitest version #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdelion
approved these changes
Jan 28, 2025
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
API tests on
mainare failing following the merge of #4072What's the cause?
We upgraded vitest from v2 to v3 (PR here) in order to resolve CVE-2025-24010. Vitest v3 has some changes to how spies are handled (release notes here) which wasn't picked up in #4072 as it wasn't rebased to
main.We could force all PRs to be rebase to
mainbefore merge using GH branch protection but I think this would be a real pain to manage for little benefit. Very few issues like this make it tomainand can be easily identified and resolves before reachproduction.