Update to latest FAAD2 Commit #354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw FAAD2 now provides a CMakeLists which makes compiling a patched faad hdc a bit easier. I updated the patch for the latest commit. It's still not good as fdk-aac.
Works just fine for me here: https://youtu.be/KYT2bGjVlQo
I wanted to nrsc5 to be able to compile easier. Most people use CMake. I am not very familiar with libtoolize.
I originally wanted to compile nrsc5 with MSVC because it doesn't depend on libc++. Plus, some people online disagree that -static is a good flag bla bla. This library requires lots of changes to get MSVC. I ended up just bringing libc with me.