Add type checking to some actions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Gotta reach those coverage targets :^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type checks to some actions.
Actions acting on wrong data types (e.x.
$inc: ["a-string", 4], or$mul: ["$.aVariable", 3], where$.aVariabledoes not exist) will now do nothing, as it should.I have not tested every possible combination of types in-game, but from the ones I've tested, I think it's safe to conclude that using $inc, $dec, and $mul with non-numbers does nothing.
Similarly, using $push, $pushunique, or $remove with non-arrays also does nothing.
The same is true if these actions are trying to use (context) variables that are undefined.
Should fix thepeacockproject/Peacock#479.