Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $eq condition where first value is null or undefined should always return false #32

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

grappigegovert
Copy link
Member

See title.
Fixes thepeacockproject/Peacock#530.

I've also added some settings / extension recommendations for vscode to make running tests a bit easier.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/index.ts 96.37% <100.00%> (+0.01%) ⬆️
tests/eq.spec.ts 100.00% <100.00%> (ø)

@AnthonyFuller AnthonyFuller changed the title Fix: $eq condition where first value is null or undefined should always return false fix: $eq condition where first value is null or undefined should always return false Nov 7, 2024
@AnthonyFuller AnthonyFuller merged commit 89d8a7b into main Nov 7, 2024
2 checks passed
@AnthonyFuller AnthonyFuller deleted the undefined-eq branch November 7, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 Years of Bad Luck challenge broken
2 participants