Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llext: export symbols, needed for aria #9855

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

lyakh
Copy link
Collaborator

@lyakh lyakh commented Feb 24, 2025

Aria needs additional exported symbols from SOF.

Aria needs additional exported symbols from SOF.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but do you know what requires those __ named functions?

@lgirdwood
Copy link
Member

Looks OK, but do you know what requires those __ named functions?

Those are compiler built-ins.
@lyakh dont we have other built ins ? (should we put built-ins in one place ?)

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 25, 2025

Looks OK, but do you know what requires those __ named functions?

Those are compiler built-ins. @lyakh dont we have other built ins ? (should we put built-ins in one place ?)

@lgirdwood there are a couple more there in numbers.c already like __udivdi3() and __divdi3()

@lgirdwood
Copy link
Member

Looks OK, but do you know what requires those __ named functions?

Those are compiler built-ins. @lyakh dont we have other built ins ? (should we put built-ins in one place ?)

@lgirdwood there are a couple more there in numbers.c already like __udivdi3() and __divdi3()

Ok, can we comment this in a followup PR - i.e. so that its obvious that CC built-ins need to go here,

@lgirdwood lgirdwood merged commit 93409b6 into thesofproject:main Feb 25, 2025
43 of 49 checks passed
@lyakh lyakh deleted the export branch February 25, 2025 13:43
@lyakh
Copy link
Collaborator Author

lyakh commented Feb 25, 2025

Looks OK, but do you know what requires those __ named functions?

Those are compiler built-ins. @lyakh dont we have other built ins ? (should we put built-ins in one place ?)

@lgirdwood there are a couple more there in numbers.c already like __udivdi3() and __divdi3()

Ok, can we comment this in a followup PR - i.e. so that its obvious that CC built-ins need to go here,

@lgirdwood #9858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants