Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firedrake outputs API has changed #360

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Firedrake outputs API has changed #360

merged 4 commits into from
Mar 7, 2024

Conversation

jwallwork23
Copy link
Contributor

Closes #359

@jwallwork23 jwallwork23 added the bug label Mar 7, 2024
@jwallwork23 jwallwork23 self-assigned this Mar 7, 2024
@jwallwork23 jwallwork23 requested a review from acse-ej321 March 7, 2024 13:48
acse-ej321
acse-ej321 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@acse-ej321 acse-ej321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joe.

@acse-ej321 acse-ej321 merged commit b73e799 into master Mar 7, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 359_fix_output_api branch March 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acse-ej321 acse-ej321 acse-ej321 approved these changes

Assignees

@jwallwork23 jwallwork23

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firedrake outputs API has changed
2 participants
@jwallwork23 @acse-ej321