Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrete turbines callback example #362

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

cpjordan
Copy link
Contributor

@cpjordan cpjordan commented Apr 9, 2024

Adds a callback to the existing discrete turbines example that allows monitoring of individual discrete turbines. We compare the results to the farm callback to make sure that the results are the same. This callback can be used with or without turbines added to the simulation for comparison in the 'ambient' case.

Callback is slow for meshes with a large number of elements in the subdomain of interest, but fine for smaller scales.

cpjordan added 2 commits April 5, 2024 11:45
- This is separate from the farm callback and allows monitoring of individual discrete turbines
- This becomes slow when the mesh becomes very large
Copy link
Contributor

@thangel thangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - and I think the callback functionality within the example is helpful to distinguish between core thetis utilities and applying application-specific extensions for use cases. It looks good and instructive

@cpjordan cpjordan merged commit 5721f80 into master Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants