Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add success and error message dialogs, and implement threading for save changes #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

duyle1402
Copy link

Hi Thiago,

Thank you for creating awesome things. When I use OpenPLC Editor to program with my ESP32 board, I noticed that when I press the "Save Changes" and "Restore Default" buttons, I don't know if the actions worked or not. To improve user experience and provide clear feedback, I have added the following enhancements:

1.Success and Error Message Dialogs:

  • Added showSuccessMessage and showErrorMessage methods to display a message dialog indicating whether the operation was successful or if there was an error.
  • These dialogs provide immediate feedback to the user, ensuring they know the result of their actions.

2.Threading for Save Changes:

  • Implemented threading in the onSaveChange method to handle the save operation in a separate thread.
  • This prevents the GUI from freezing and allows the button to be re-enabled after the save operation is complete.

These changes enhance the usability of the application by providing clear and immediate feedback to users. You can accept this pull request or not, or you can consider an alternative implementation in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant