-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps,refactor: Remove pkcs11 resolver #3432
Open
Bravo555
wants to merge
3
commits into
thin-edge:main
Choose a base branch
from
Bravo555:refactor/remove-pkcs11-resolver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+33
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Robot Results
Failed Tests
|
For rustls we have `default-features = false` because we don't want to use aws-lc-rs, but it also disabled other default features: `std` and `tls12`. These features have been reenabled. Feature determination scheme appears to be wonky as when I started working on p11 server, rustls screamed at me about `ClientConfig::builder` not existing. Indeed it requires `rustls/std` feature, but it worked fine before. Signed-off-by: Marcel Guzik <[email protected]>
This new version exposes `SingleKeyAndCert` resolver that we can use to remove some code. Signed-off-by: Marcel Guzik <[email protected]>
The resolver doesn't do anything PKCS#11 specific and can be trivially replaced with rustls `SingleKeyAndCert` resolver. Signed-off-by: Marcel Guzik <[email protected]>
850a548
to
707b6a0
Compare
So it turns out upgrading rustls from 0.23.22 to 0.23.23 broke the verification of the server TLS certificate in the test image. Trying to connect to the broker returns an error:
Investigating the cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A subset of trivial changes extracted from and not related to main functionality of #3421.
Updates rustls to 0.23.23 and removes unnecessary
pkcs11::Pkcs11Resolver
, which doesn't really do anything pkcs11-specific.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINES