Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add device.csr_path to cloud profiles #3441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ruadhri17
Copy link
Contributor

Proposed changes

As mentioned in #3413 user could not specified device.csr_path per cloud profile. This PR appends multi profile config with csr_path and replaces old approach of accessing config value in tedge cert create-csr.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Krzysztof Piotrowski <[email protected]>
@Ruadhri17 Ruadhri17 temporarily deployed to Test Pull Request March 3, 2025 09:45 — with GitHub Actions Inactive
@Ruadhri17 Ruadhri17 added theme:c8y Theme: Cumulocity related topics theme:certificates Theme: Device certificate topics theme:aws Theme: AWS cloud related topics theme:az Theme: Azure IoT related topics bug Something isn't working and removed bug Something isn't working labels Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../tedge_config/src/tedge_config_cli/tedge_config.rs 34.61% 10 Missing and 7 partials ⚠️
crates/core/tedge/src/cli/certificate/cli.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
583 0 3 583 100 1h38m58.468912999s

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for a system test. Can be added under /tests/RobotFramework/tests/tedge/certificate_signing_request.robot

Comment on lines -41 to -42
#[clap(long = "output-path", global = true, value_hint = ValueHint::FilePath)]
output_path: Option<Utf8PathBuf>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why --output_path option is removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:aws Theme: AWS cloud related topics theme:az Theme: Azure IoT related topics theme:c8y Theme: Cumulocity related topics theme:certificates Theme: Device certificate topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants