Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add robot tests for cli tab completions #3443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

Add some tests which verify tedge responds correctly to a shell completion request. These tests simulate the command that fish uses when requesting tedge completions and checks that the response is the expected list of values and accompanying values. fish output is used as it is very human-readable and includes help text. These tests don't verify that the completion script is installed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request March 3, 2025 16:03 — with GitHub Actions Inactive
@reubenmiller reubenmiller added theme:testing Theme: Testing theme:cli Theme: cli related topics labels Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
587 1 3 588 99.83 1h35m49.122005999s

Failed Tests

Name Message ⏱️ Duration Suite
Tedge has completions for cloud profile names Multiline strings are different: --- first +++ second @@ -1,4 +1,4 @@ +test other -test azure aws 8.709 s Tedge Completions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:cli Theme: cli related topics theme:testing Theme: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants