Allows discardableResult where output is Data

Defaults headers and queries to String
thirdfort · Oct 12, 2022 · cfadef1 · cfadef1
1 parent 30648bc
commit cfadef1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/Sources/Endpoints/EndpointService.swift b/Sources/Endpoints/EndpointService.swift
@@ -124,6 +124,7 @@ public extension EndpointService {
     ///   - domain: The `domain` associated with this endpoint
     ///   - body: The body data to include in the URLRequest
     /// - Returns: The data and response returned for this endpoint request
+    @discardableResult
     func perform<E>(_ endpoint: E) async throws -> (Data, HTTPURLResponse)
     where E: EncodableEndpoint, E.Input == Data
     {
@@ -136,6 +137,7 @@ public extension EndpointService {
     ///   - domain: The `domain` associated with this endpoint
     ///   - body: The encodable body to include in the URLRequest
     /// - Returns: The data and response returned for this endpoint request
+    @discardableResult
     func perform<E>(_ endpoint: E) async throws -> (Data, HTTPURLResponse)
     where E: EncodableEndpoint
     {
@@ -147,6 +149,7 @@ public extension EndpointService {
 // MARK: Private
 
 private extension EndpointService {
+    @discardableResult
     func encode<E: EncodableEndpoint>(endpoint: E) throws -> Data {
         do {
             let result = try endpoint.encode()

diff --git a/Sources/Endpoints/Models/Header.swift b/Sources/Endpoints/Models/Header.swift
@@ -1,7 +1,7 @@
 import Foundation
 
 public protocol HeaderKey {
-    associatedtype Value: CustomStringConvertible
+    associatedtype Value: CustomStringConvertible = String
     static var name: String { get }
 }
 

diff --git a/Sources/Endpoints/Models/Query.swift b/Sources/Endpoints/Models/Query.swift
@@ -2,7 +2,7 @@ import Foundation
 import SwiftUI
 
 public protocol QueryKey {
-    associatedtype Value: CustomStringConvertible
+    associatedtype Value: CustomStringConvertible = String
     static var name: String { get }
 }