-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding localized Mur\SA-Mur absorbers #167
base: master
Are you sure you want to change the base?
Conversation
Added two example scripts to openEMS\Python\Tutorials |
e0d262f
to
cde850b
Compare
Test script with MSL Rebasing engine extensions with latest ij indexing stuff
Checked that this commit\push compiles. Ready for instructions |
A few initial comments and things you need to change:
|
Thank you for reviewing this so quickliy!
Sure did! The lumped elements PR was based on Lorentz material, BTW. Will clean it up soon enough, as requested.
That's what I get for moving slowly :). I'll look into it.
No problem, although one could claim it can be done with placing the waveguide on the boundaries... I'll figure something out. I wanted to implement a coax->waveguide transition, but the CAD work drove me nuts. |
After starting to get acquainted with the new ArrayLib, I have a question:
I don't know if this question is for @thliebig or @biergaizi, who wrote this. Cheers |
I'm not sure I understand the question fully, but yes, for the 2D arrays I guess you should use the ArrayIJ instead. This will create a single/linear array, but can be efficiently accessed like a 2D array |
There are two additions in this pull requests:
Same use cases as specified in the CSXCAD PR
Two types or Mur B.Cs were implemented:
All original functionality is maintained. All functions can be used as before, as well.
[1] Betz, Vaughn Timothy, and R. Mittra. "Absorbing boundary conditions for the finite-difference time-domain analysis of guided-wave structures." Coordinated Science Laboratory Report no. UILU-ENG-93-2243 (1993).