Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store keys and values seperately #15

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Conversation

BeastyBlacksmith
Copy link
Contributor

I haven't thought through every implication of this, but I think this makes implementation of dictionary behaviour easier.

I implemented get, + and - with this and you get getindex for free then, so fixes #12 .

@thofma
Copy link
Owner

thofma commented Dec 5, 2022

Yes, I agree that this is cleaner. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Base: 100.00% // Head: 99.57% // Decreases project coverage by -0.42% ⚠️

Coverage data is based on head (16484de) compared to base (711f1d6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #15      +/-   ##
===========================================
- Coverage   100.00%   99.57%   -0.43%     
===========================================
  Files            1        1              
  Lines          207      238      +31     
===========================================
+ Hits           207      237      +30     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/Tally.jl 99.57% <100.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thofma
Copy link
Owner

thofma commented Dec 6, 2022

I pushed some small tweaks.

@thofma thofma merged commit bd38c30 into thofma:master Dec 7, 2022
@thofma
Copy link
Owner

thofma commented Dec 7, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Base.getindex(t::TallyT, k)
3 participants