Many updates including new held() and retrigger() #15
Conversation
Updated Constructors to do all the pin() and interval() setups. All the setup can now be done in one step when instantiating the object. Added held() and retrigger(). See examples. Updated other examples to use the new constructor.
AlbertPhan
changed the title
The thing is you want to setup the pin before attaching it. That is why it was moved to the separate attach() function.
retrigger() is a common request and held() is an interesting addition. Instead of having a separate variable, maybe the held time could be passed in the function? Like held(500) ? |
|
Oh I see what you mean with the attach(). I'll move it out of the constructor and do some more updates. |
|
I can move the attach() function to run at the first time update() is called so we could still have it all in one constructor and after the pin is setup. I'm not sure I can add the held(500) easily since all the code for that function is in update() and requires a separate variable. I did have to add many more variables to the program to get the functionality of held and retrigger but I feel it was worth the extra bytes. I'll take a look again and see if I can reduce the extra variables in any way. |
attach() is now called the first time update() is run so the pin setup is before attach(). I also removed previous_millis_retrigger to save 4 bytes. Also updated retrigger.ino example with a few more comments.
Function wasn't properly returning a false when held() was low.
This caused people to use retrigger() to have it constantly return a 1 when using active low buttons.
|
Whats the status on this? Looks very handy! |
|
Should be on a different object, this would increase the size of the object, which is not good on a limited Arduino Uno with already too many objects going around. Might be implemented in a children class for example, that way if we don't need this extra functionality we can just instantiate the parent and keep a smaller object. |
|
Sounds like a good idea. Currently I am not working on this as one can
imagine since I haven't updated it in a long time. When/if I come back to
this I'll try to implement a child class. Feel free to take this fork over
if you want.
On Jan 3, 2018 2:11 PM, "Nelson Vides" <[email protected]> wrote:
Should be on a different object, this would increase the size of the
object, which is not good on a limited Arduino Uno with already too many
objects going around. Might be implemented in a children class for example,
that way if we don't need this extra functionality we can just instantiate
the parent and keep a smaller object.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALHgSmT9APHyPe-wxMP7smw3vWEAzaENks5tG_sggaJpZM4D1l29>
.
|
Updated Constructors to do all the pin() and interval() setups. All the
setup can now be done in one step when instantiating the object. Added
held() and retrigger(). See examples. Updated other examples to use the
new constructor.