Refactored Classifier to an sklearn estimator #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to use sklearn `OneVsRestClassifier` (for multi-class tasks which are not currently supported by this repository), i've changed the `Classifier` class to be an sklearn estimator (by using inheritance from `BaseEstimator` and `ClassifierMixin`). Also, I've added `predict_proba` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've wanted to use your classifier for a multiclass problem. The easiest way I've thought about is using sklearn
OneVsRestClassifierand refactoring yourClassifierto be an sklearn estimator (by using inheritance fromBaseEstimatorandClassifierMixin). Also, I've addedpredict_probafunction.So I've thought it would be nice to open a PR for anyone want to use this classifier for multiclass problems 😃