Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Paging (Shared & Android) #117

Merged
merged 28 commits into from
Jan 3, 2024
Merged

Implement Paging (Shared & Android) #117

merged 28 commits into from
Jan 3, 2024

Conversation

thomaskioko
Copy link
Owner

Description

This MR adds paging implementation on the Android app and does some minor cleanup.

Other changes:

  • The iOS app no longer uses the SMP package. We are using the framework from the shared module.
  • Create an Empty "More screen."
  • Update Entity mapping implementation.

Demo

PaginationAndroid.mp4

@thomaskioko
Delete unused dependencies.
b7d03ef
@thomaskioko
Add paging dependencies.
e80e1f8
@thomaskioko
Cleanup mapping and move mapping implementation to the dao
adbb351
@thomaskioko
Create generic remote paging mediator.
424be53
@thomaskioko
Implement paging on popular shows.
813c283
@thomaskioko
Implement paging on upcoming shows.
056876f
@thomaskioko
Implement paging on topRated shows.
1dd9ef9
@thomaskioko
Implement paging on trending shows.
bf2bd84
@thomaskioko
Rename action.
b796b5b
@thomaskioko
Add paging implementation to presenter.
7602095
@thomaskioko
Make spotless happy.
0d392fa
@thomaskioko
Remove KmmBridge
8ae75b8
@thomaskioko
Minor UI cleanup
63bdd41
@thomaskioko
Minor cleanup
c10d54e
@thomaskioko
Get rid of SMP and use shared framework.
b39fb5b
@thomaskioko
Remove frame height
ca984a0
@thomaskioko
Update more text and add click action.
1833c8f
@thomaskioko
Remove duplicate import
53db053
@thomaskioko
Implement more ui screen (empty)
654894e
@thomaskioko
Minor cleanup
e6021d4
@thomaskioko
Add saftey dependencies. These are needed or the build will fail.
ff1ce61
@thomaskioko
Add paging compose dependency and bump up dependencies.
61077ee
@thomaskioko
Add paging implementation.
a082186
@thomaskioko
Make spotless happy
f624c06
@thomaskioko
Add Toolbar ScrollBehavior
5f2d98e
@thomaskioko
Rename back object.
45f2d37
@thomaskioko
Add paging dependency to README
b980c57
@thomaskioko thomaskioko added android Android related task/issues shared Shared module task/issues labels Jan 3, 2024
@thomaskioko thomaskioko merged commit bd2cdca into main Jan 3, 2024
5 checks passed
@thomaskioko thomaskioko mentioned this pull request Jan 3, 2024
Closed
@thomaskioko thomaskioko deleted the feature/implement-paging branch July 8, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android Android related task/issues shared Shared module task/issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomaskioko