Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify notebooks to retrieve data from operate first public bucket #47

Merged

Conversation

mayaCostantini
Copy link
Contributor

@mayaCostantini mayaCostantini commented Nov 16, 2021

Related Issues and Dependencies

Related to #31

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

The notebooks used for thoth datasets analysis now allow users to access the datasets on an operate first public bucket instead of downloading them locally.

  • Learn how to access notebooks in JupyterHub available through Open Data Hub on Operate First spawning Experimental Elyra image and learn about Thoth datasets.

  • Verify/Request the credentials of the public bucket available on Operate First.

  • Place datasets on that bucket under thoth/datasets/{dataset-name} using aws/s3 CLI from your local terminal.

  • Modify notebooks to retrieve data from s3 instead of using local datasets.

  • Push changes to thoth-station/datasets using Git extension.

  • Create a release using Kebechet and AICoE-CI

  • Add image to JupyterHub list of images, so that users can learn about thoth datasets.

  • Demo

Description

The changes principally consist in adding environment variables to the notebooks that contain the necessary credentials to access the datasets on the public bucket and in modifying the code to retrieve the datasets from the correct prefixes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 16, 2021
@mayaCostantini
Copy link
Contributor Author

/assign @pacospace

Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! very nice work!! 💯

@sesheta
Copy link
Member

sesheta commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@sesheta sesheta merged commit b838bbf into thoth-station:master Nov 17, 2021
@mayaCostantini mayaCostantini deleted the add-datasets-image-operatefirst branch November 17, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants