sesheta (prow / commenter) auto-closes issues when it should not

[codificat]

Describe the bug

We have seen the bots auto-close some issuses, supposedly due to lifecycle ("rotten"), when they did not meet the conditions.

Problems observed:

• closing issues that have the lifecycle/frozen label (these should never be auto-closed)
• closing issues at the same time that the lifecycle/rotten label is added (it should wait an additional 30 days before closing them)

To Reproduce
Wait enough time for issues to hit a lifecycle milestone (30 days, 720 hours)

Expected behavior
The lifecycle of the issues is properly tracked and managed by the bots using the appropriate labels.

Screenshots
Some examples of misbehaviour observed:

• [8pt] Estimate wait time for advise requests metrics-exporter#727 (comment) frozen?
• Relax solver rules init-job#425
• Add adviser-validate-unit-schema configuration to configmap #532 (comment)
• add liveness/readiness probes package-update-job#140 (comment)
• Add datasets image to Operate First datasets#31 (comment)
• PEP-665 support micropipenv#184 (comment)

On the other hand, the bot has also been seen to act correctly, for example:

• [spike] on integrating stackrox with aicoe-ci core#281 (comment)
• Wrong value for metadata author for TensorFlow from AICoE. storages#1717

[codificat]

With the version bump in #2026 this seems to be fixed.

Looking at the logs and the history around when this was working / stopped working (early July), I believe that the cause of the problem was related to newline handling, fixed in kubernetes/test-infra#22922.

/close

[sesheta]

@codificat: Closing this issue.

In response to this:

With the version bump in #2026 this seems to be fixed.

Looking at the logs and the history around when this was working / stopped working (early July), I believe that the cause of the problem was related to newline handling, fixed in kubernetes/test-infra#22922.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.